Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files

net/sf/fridaymvc/sample/actions/AddUser.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	30
	Line has trailing spaces.	32
	Line has trailing spaces.	34
	Line is longer than 80 characters.	35
	Line is longer than 80 characters.	36
	Line is longer than 80 characters.	37
	Line is longer than 80 characters.	38
	Line is longer than 80 characters.	39
	Line is longer than 80 characters.	40
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	47
	Missing a Javadoc comment.	47
	Line contains a tab character.	49
	Line contains a tab character.	50
	Line has trailing spaces.	51
	Line contains a tab character.	51
	Line contains a tab character.	52
	Line has trailing spaces.	53
	Line contains a tab character.	53
	Line contains a tab character.	54
	Line contains a tab character.	55
	Line contains a tab character.	56
	Line contains a tab character.	57
	Line contains a tab character.	58
	Line contains a tab character.	59
	Line contains a tab character.	60
	Line contains a tab character.	61
	Line has trailing spaces.	62
	Line contains a tab character.	62
	Line contains a tab character.	63
	Line contains a tab character.	64
	Line contains a tab character.	65
	'}' should be on the same line.	66
	'catch' is not followed by whitespace.	67

net/sf/fridaymvc/sample/actions/CreateTestData.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	31
	Line has trailing spaces.	39
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	39
	Missing a Javadoc comment.	39
	Line is longer than 80 characters.	40
	Line has trailing spaces.	41
	Line has trailing spaces.	45
	Line has trailing spaces.	47
	Line has trailing spaces.	53
	Line has trailing spaces.	55
	Line has trailing spaces.	57
	Line has trailing spaces.	59
	Line has trailing spaces.	68
	Line has trailing spaces.	70

net/sf/fridaymvc/sample/actions/Login.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	28
	Line has trailing spaces.	30
	Line is longer than 80 characters.	31
	Line is longer than 80 characters.	32
	Line contains a tab character.	35
	Line contains a tab character.	36
	Line contains a tab character.	37
	Line contains a tab character.	38
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	38
	Missing a Javadoc comment.	38
	Line contains a tab character.	39
	Line contains a tab character.	40
	Line is longer than 80 characters.	41
	Line contains a tab character.	41
	Line contains a tab character.	42
	'if' is not followed by whitespace.	42
	Line contains a tab character.	43
	Line contains a tab character.	44
	Line contains a tab character.	45
	Line contains a tab character.	46
	Line contains a tab character.	47
	Line contains a tab character.	48

net/sf/fridaymvc/sample/actions/Logout.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	32
	Missing a Javadoc comment.	32

net/sf/fridaymvc/sample/actions/RemoveUser.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	28
	Line has trailing spaces.	30
	Line has trailing spaces.	32
	Line is longer than 80 characters.	33
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	40
	Missing a Javadoc comment.	40
	Line is longer than 80 characters.	42

net/sf/fridaymvc/sample/actions/package.html

Error		Line
	Missing package documentation file.	0

net/sf/fridaymvc/sample/hibernate/HibernatePermission.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line is longer than 80 characters.	25
	Line contains a tab character.	27
	Line is longer than 80 characters.	30
	Missing a Javadoc comment.	31
	Variable 'permissionUid' must be private and have accessor methods.	31
	Line has trailing spaces.	32
	Line has trailing spaces.	34
	Line has trailing spaces.	35
	Line contains a tab character.	36
	Line contains a tab character.	37
	Line contains a tab character.	38
	Line contains a tab character.	39
	Expected an @return tag.	41
	Method 'getName' is not designed for extension - needs to be abstract, final or empty.	41
	Line has trailing spaces.	44
	Line contains a tab character.	48
	Line contains a tab character.	49
	Line contains a tab character.	50
	Method 'getPermissionUid' is not designed for extension - needs to be abstract, final or empty.	52
	Method 'setPermissionUid' is not designed for extension - needs to be abstract, final or empty.	58
	Parameter permissionUid should be final.	58
	'permissionUid' hides a field.	58
	Line has trailing spaces.	61
	Line has trailing spaces.	63
	Line contains a tab character.	64
	Line contains a tab character.	65
	Line contains a tab character.	66
	Expected an @return tag.	68
	Method 'getMask' is not designed for extension - needs to be abstract, final or empty.	68

net/sf/fridaymvc/sample/hibernate/HibernateRole.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line contains a tab character.	29
	Missing a Javadoc comment.	33
	Variable 'roleUid' must be private and have accessor methods.	33
	Missing a Javadoc comment.	34
	Variable 'name' must be private and have accessor methods.	34
	Line contains a tab character.	39
	Line contains a tab character.	40
	Line contains a tab character.	41
	Method 'getRoleUid' is not designed for extension - needs to be abstract, final or empty.	43
	Method 'setRoleUid' is not designed for extension - needs to be abstract, final or empty.	49
	Parameter roleUid should be final.	49
	'roleUid' hides a field.	49
	Line has trailing spaces.	53
	Line has trailing spaces.	54
	Line contains a tab character.	54
	Line contains a tab character.	55
	Line contains a tab character.	56
	Line has trailing spaces.	57
	Line contains a tab character.	59
	Line has trailing spaces.	60
	Line contains a tab character.	60
	Line has trailing spaces.	61
	Line contains a tab character.	62
	Line contains a tab character.	63
	Expected an @return tag.	65
	Method 'getPermissions' is not designed for extension - needs to be abstract, final or empty.	65
	'if' construct must use '{}'s.	67
	'if' is not followed by whitespace.	67
	Line has trailing spaces.	73
	Line contains a tab character.	74
	Line contains a tab character.	75
	Line contains a tab character.	76
	Line contains a tab character.	77
	Method 'getName' is not designed for extension - needs to be abstract, final or empty.	79
	Line has trailing spaces.	81

net/sf/fridaymvc/sample/hibernate/HibernateUser.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line contains a tab character.	29
	Missing a Javadoc comment.	33
	Variable 'userUid' must be private and have accessor methods.	33
	Missing a Javadoc comment.	34
	Variable 'username' must be private and have accessor methods.	34
	Missing a Javadoc comment.	35
	Variable 'password' must be private and have accessor methods.	35
	Missing a Javadoc comment.	36
	Variable 'email' must be private and have accessor methods.	36
	Missing a Javadoc comment.	37
	Variable 'firstName' must be private and have accessor methods.	37
	Missing a Javadoc comment.	38
	Variable 'surName' must be private and have accessor methods.	38
	Missing a Javadoc comment.	39
	Variable 'phoneNumber' must be private and have accessor methods.	39
	Line has trailing spaces.	40
	Line has trailing spaces.	41
	Line contains a tab character.	45
	Line contains a tab character.	46
	Line contains a tab character.	47
	Method 'getUserUid' is not designed for extension - needs to be abstract, final or empty.	49
	Method 'setUserUid' is not designed for extension - needs to be abstract, final or empty.	55
	Parameter userUid should be final.	55
	'userUid' hides a field.	55
	Line has trailing spaces.	58
	Line has trailing spaces.	60
	Line has trailing spaces.	61
	Line has trailing spaces.	62
	Line contains a tab character.	64
	Line contains a tab character.	65
	Line has trailing spaces.	66
	Line contains a tab character.	68
	Line has trailing spaces.	69
	Line contains a tab character.	69
	Line has trailing spaces.	70
	Line contains a tab character.	71
	Line has trailing spaces.	72
	Line contains a tab character.	72
	Expected an @return tag.	74
	Method 'getRoles' is not designed for extension - needs to be abstract, final or empty.	74
	'if' construct must use '{}'s.	76
	'if' is not followed by whitespace.	76
	Line has trailing spaces.	78
	Line has trailing spaces.	81
	Line contains a tab character.	82
	Line contains a tab character.	83
	Line contains a tab character.	84
	Line has trailing spaces.	85
	Method 'getEmail' is not designed for extension - needs to be abstract, final or empty.	87
	Method 'setEmail' is not designed for extension - needs to be abstract, final or empty.	93
	Parameter email should be final.	93
	'email' hides a field.	93
	Line has trailing spaces.	98
	Line contains a tab character.	99
	Line contains a tab character.	100
	Line contains a tab character.	101
	Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty.	103
	Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty.	109
	Parameter firstName should be final.	109
	'firstName' hides a field.	109
	Line contains a tab character.	115
	Line contains a tab character.	116
	Line contains a tab character.	117
	Method 'getPassword' is not designed for extension - needs to be abstract, final or empty.	119
	Method 'setPassword' is not designed for extension - needs to be abstract, final or empty.	125
	Parameter password should be final.	125
	'password' hides a field.	125
	Line has trailing spaces.	130
	Line contains a tab character.	131
	Line contains a tab character.	132
	Line contains a tab character.	133
	Method 'getSurName' is not designed for extension - needs to be abstract, final or empty.	135
	Method 'setSurName' is not designed for extension - needs to be abstract, final or empty.	141
	Parameter surName should be final.	141
	'surName' hides a field.	141
	Line has trailing spaces.	146
	Line contains a tab character.	147
	Line contains a tab character.	148
	Line contains a tab character.	149
	Line contains a tab character.	150
	Method 'getUsername' is not designed for extension - needs to be abstract, final or empty.	152
	Method 'setUsername' is not designed for extension - needs to be abstract, final or empty.	158
	Parameter username should be final.	158
	'username' hides a field.	158
	Line has trailing spaces.	163
	Line contains a tab character.	164
	Line contains a tab character.	165
	Line contains a tab character.	166
	Method 'getPhoneNumber' is not designed for extension - needs to be abstract, final or empty.	168
	Method 'setPhoneNumber' is not designed for extension - needs to be abstract, final or empty.	174
	Parameter phoneNumber should be final.	174
	'phoneNumber' hides a field.	174

net/sf/fridaymvc/sample/hibernate/dao/PermissionDao.java

Error		Line
	File does not end with a newline.	0

net/sf/fridaymvc/sample/hibernate/dao/PermissionDao.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Expected an @return tag.	31
	Line is longer than 80 characters.	31
	Redundant 'public' modifier.	31
	Expected @param tag for 'hp'.	31

net/sf/fridaymvc/sample/hibernate/dao/RoleDao.java

Error		Line
	File does not end with a newline.	0

net/sf/fridaymvc/sample/hibernate/dao/RoleDao.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Expected an @return tag.	33
	Redundant 'public' modifier.	33
	Expected @param tag for 'hr'.	33
	Redundant 'public' modifier.	38
	Expected @param tag for 'hr'.	38
	Missing a Javadoc comment.	40
	Redundant 'public' modifier.	40
	Expected an @return tag.	46
	Redundant 'public' modifier.	46
	Expected @param tag for 'name'.	46

net/sf/fridaymvc/sample/hibernate/dao/UserDao.java

Error		Line
	File does not end with a newline.	0

net/sf/fridaymvc/sample/hibernate/dao/UserDao.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Missing a Javadoc comment.	31
	Redundant 'public' modifier.	31
	Missing a Javadoc comment.	33
	Redundant 'public' modifier.	33
	Missing a Javadoc comment.	36
	Redundant 'public' modifier.	36
	Redundant 'public' modifier.	41
	Expected @param tag for 'user'.	41
	Expected an @return tag.	46
	Redundant 'public' modifier.	46
	Expected @param tag for 'userUid'.	46

net/sf/fridaymvc/sample/hibernate/dao/impl/PermissionDaoImpl.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	27
	Line is longer than 80 characters.	31
	Expected an @return tag.	37
	Method 'saveOrUpdateCopy' is not designed for extension - needs to be abstract, final or empty.	37
	Parameter hp should be final.	37
	Expected @param tag for 'hp'.	37
	Line is longer than 80 characters.	38
	Line has trailing spaces.	40

net/sf/fridaymvc/sample/hibernate/dao/impl/RoleDaoImpl.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	32
	Expected an @return tag.	42
	Method 'saveOrUpdateCopy' is not designed for extension - needs to be abstract, final or empty.	42
	Parameter hr should be final.	42
	Expected @param tag for 'hr'.	42
	Method 'update' is not designed for extension - needs to be abstract, final or empty.	49
	Parameter hr should be final.	49
	Expected @param tag for 'hr'.	49
	Method 'save' is not designed for extension - needs to be abstract, final or empty.	53
	Missing a Javadoc comment.	53
	Parameter hr should be final.	53
	Line has trailing spaces.	54
	Expected an @return tag.	61
	Method 'findRoleByName' is not designed for extension - needs to be abstract, final or empty.	61
	Expected @param tag for 'name'.	61
	Line is longer than 80 characters.	62
	Line is longer than 80 characters.	64
	Line is longer than 80 characters.	66
	Parameter session should be final.	66
	Line is longer than 80 characters.	67
	Line contains a tab character.	68
	Line contains a tab character.	69

net/sf/fridaymvc/sample/hibernate/dao/impl/UserDaoImpl.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	35
	Method 'findAllUsers' is not designed for extension - needs to be abstract, final or empty.	40
	Missing a Javadoc comment.	40
	Line has trailing spaces.	43
	Line is longer than 80 characters.	45
	Method 'findByUsernamePassword' is not designed for extension - needs to be abstract, final or empty.	45
	Missing a Javadoc comment.	45
	Line is longer than 80 characters.	48
	Line is longer than 80 characters.	50
	Parameter session should be final.	50
	Line is longer than 80 characters.	51
	Line contains a tab character.	52
	Line contains a tab character.	53
	Line contains a tab character.	54
	Method 'save' is not designed for extension - needs to be abstract, final or empty.	60
	Missing a Javadoc comment.	60
	Parameter hu should be final.	60
	Method 'update' is not designed for extension - needs to be abstract, final or empty.	67
	Parameter user should be final.	67
	Expected @param tag for 'user'.	67
	Line is longer than 80 characters.	72
	Method 'removeUserByUserUid' is not designed for extension - needs to be abstract, final or empty.	74
	Missing a Javadoc comment.	74
	Parameter userUid should be final.	74
	Line has trailing spaces.	75
	Line is longer than 80 characters.	75
	Line contains a tab character.	75

net/sf/fridaymvc/sample/hibernate/dao/impl/package.html

Error		Line
	Missing package documentation file.	0

net/sf/fridaymvc/sample/hibernate/dao/package.html

Error		Line
	Missing package documentation file.	0

net/sf/fridaymvc/sample/hibernate/package.html

Error		Line
	Missing package documentation file.	0

net/sf/fridaymvc/sample/models/Bottom.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	26
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	34
	Missing a Javadoc comment.	34

net/sf/fridaymvc/sample/models/Navi.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	30
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	39
	Missing a Javadoc comment.	39
	Line has trailing spaces.	41
	'if' construct must use '{}'s.	42
	Line has trailing spaces.	42
	Line is longer than 80 characters.	42
	'if' is not followed by whitespace.	42

net/sf/fridaymvc/sample/models/main/Admin.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	26
	Line has trailing spaces.	28
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	36
	Missing a Javadoc comment.	36
	Line has trailing spaces.	37

net/sf/fridaymvc/sample/models/main/Main.java

Error		Line
	Missing a header - not enough lines in file.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	7
	Line has trailing spaces.	9
	Line has trailing spaces.	15
	Line has trailing spaces.	26
	Method 'service' is not designed for extension - needs to be abstract, final or empty.	34
	Missing a Javadoc comment.	34

net/sf/fridaymvc/sample/models/main/package.html

Error		Line
	Missing package documentation file.	0

net/sf/fridaymvc/sample/models/package.html

Error		Line
	Missing package documentation file.	0